Replace Oasis headers with public domain headers #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
issue76
branch
2 times, most recently
from
163f22a to
aa04e09
Compare
Headers pulled from https://github.com/latchset/pkcs11-headers Fixes latchset#76 Signed-off-by: Simo Sorce <[email protected]>
|
@Jakuje @sahanaprasad07 can one of you review? |
bluca
reviewed
Nov 6, 2023
| #include "oasis/pkcs11.h" | ||
|
|
||
| #endif /* P11PROV_PKCS11_H_ */ | ||
| /* This file is in the Public Domain */ |
There was a problem hiding this comment.
Shouldn't this still use a SPDX line, pointing to the custom local identifier defined for this?
There was a problem hiding this comment.
ie: /* SPDX-License-Identifier: LicenseRef-Public-Domain-PKCS11-Headers */
There was a problem hiding this comment.
This is the untouched original file as downloaded form the pkcs11-headers project.
The connection between SPDX identifier and the file in in .reuse/dep5
|
TY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76